sbp2: did not clean up after scsi_add_device() failed If scsi_add_device() at the end of sbp2_start_device() fails, e.g. due to transport errors during SCSI inquiry, sbp2 needs to log out of the device and release all associated resources. Signed-off-by: Stefan Richter --- linux/drivers/ieee1394-16/sbp2.c 2005-12-11 02:38:06.000000000 +0100 +++ linux/drivers/ieee1394/sbp2.c 2005-12-11 19:11:01.000000000 +0100 @@ -964,6 +964,8 @@ alloc_fail: error = scsi_add_device(scsi_id->scsi_host, 0, scsi_id->ud->id, 0); if (error) { SBP2_ERR("scsi_add_device failed"); + sbp2_logout_device(scsi_id); + sbp2_remove_device(scsi_id); return error; }