Date: Thu, 2 Nov 2006 21:16:08 +0100 (CET) From: Stefan Richter Subject: ieee1394: sbp2: use list_move_tail() It's OK to reorder list_del() and sbp2util_free_command_dma() here. Signed-off-by: Stefan Richter --- drivers/ieee1394/sbp2.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) Index: linux/drivers/ieee1394/sbp2.c =================================================================== --- linux.orig/drivers/ieee1394/sbp2.c 2006-11-01 23:36:54.000000000 +0100 +++ linux/drivers/ieee1394/sbp2.c 2006-11-02 00:44:05.000000000 +0100 @@ -619,9 +619,8 @@ static void sbp2util_mark_command_comple struct sbp2_lu *lu, struct sbp2_command_info *cmd) { - list_del(&cmd->list); sbp2util_free_command_dma(cmd); - list_add_tail(&cmd->list, &lu->cmd_orb_completed); + list_move_tail(&cmd->list, &lu->cmd_orb_completed); } /*