Date: Sun, 21 Jan 2007 20:46:45 +0100 (CET) From: Stefan Richter Subject: firewire: fix failure path in ohci_enable_phys_dma "goto out" happens with the lock taken. Signed-off-by: Stefan Richter Signed-off-by: Kristian Høgsberg --- Index: linux/drivers/firewire/fw-ohci.c =================================================================== --- linux.orig/drivers/firewire/fw-ohci.c 2007-01-19 11:59:42.000000000 +0100 +++ linux/drivers/firewire/fw-ohci.c 2007-01-19 12:12:38.000000000 +0100 @@ -850,10 +850,8 @@ ohci_enable_phys_dma(struct fw_card *car 1 << (node_id - 32)); } flush_writes(ohci); - - spin_unlock_irqrestore(&ohci->lock, flags); - out: + spin_unlock_irqrestore(&ohci->lock, flags); return retval; }