Date: Mon, 22 Jan 2007 19:17:37 +0100 From: Adrian Bunk Subject: [-mm patch] firewire: cleanups This patch contains the following cleanups: - "extern inline" -> "static inline" - fw-topology.c: make struct fw_node_create static Signed-off-by: Adrian Bunk Signed-off-by: Stefan Richter Index: linux-2.6.20-rc5/drivers/firewire/fw-topology.c =================================================================== --- linux-2.6.20-rc5.orig/drivers/firewire/fw-topology.c +++ linux-2.6.20-rc5/drivers/firewire/fw-topology.c @@ -92,7 +92,7 @@ static int get_port_type(u32 *sid, int p return (sid[index] >> shift) & 0x03; } -struct fw_node *fw_node_create(u32 sid, int port_count, int color) +static struct fw_node *fw_node_create(u32 sid, int port_count, int color) { struct fw_node *node; Index: linux-2.6.20-rc5/drivers/firewire/fw-transaction.c =================================================================== --- linux-2.6.20-rc5.orig/drivers/firewire/fw-transaction.c +++ linux-2.6.20-rc5/drivers/firewire/fw-transaction.c @@ -106,7 +106,7 @@ transmit_complete_callback(struct fw_pac } } -void +static void fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel, int node_id, int generation, int speed, unsigned long long offset, void *payload, size_t length) Index: linux-2.6.20-rc5/drivers/firewire/fw-transaction.h =================================================================== --- linux-2.6.20-rc5.orig/drivers/firewire/fw-transaction.h +++ linux-2.6.20-rc5/drivers/firewire/fw-transaction.h @@ -198,7 +198,7 @@ struct fw_transaction { void *callback_data; }; -extern inline struct fw_packet * +static inline struct fw_packet * fw_packet(struct list_head *l) { return list_entry (l, struct fw_packet, link); Index: linux-2.6.20-rc5/drivers/firewire/fw-topology.h =================================================================== --- linux-2.6.20-rc5.orig/drivers/firewire/fw-topology.h +++ linux-2.6.20-rc5/drivers/firewire/fw-topology.h @@ -57,13 +57,13 @@ struct fw_node { struct fw_port ports[0]; }; -extern inline struct fw_node * +static inline struct fw_node * fw_node(struct list_head *l) { return list_entry (l, struct fw_node, link); } -extern inline struct fw_node * +static inline struct fw_node * fw_node_get(struct fw_node *node) { atomic_inc(&node->ref_count); @@ -71,7 +71,7 @@ fw_node_get(struct fw_node *node) return node; } -extern inline void +static inline void fw_node_put(struct fw_node *node) { if (atomic_dec_and_test(&node->ref_count)) Index: linux-2.6.20-rc5/drivers/firewire/fw-ohci.c =================================================================== --- linux-2.6.20-rc5.orig/drivers/firewire/fw-ohci.c +++ linux-2.6.20-rc5/drivers/firewire/fw-ohci.c @@ -147,7 +147,7 @@ struct fw_ohci { struct iso_context *ir_context_list; }; -extern inline struct fw_ohci *fw_ohci(struct fw_card *card) +static inline struct fw_ohci *fw_ohci(struct fw_card *card) { return container_of(card, struct fw_ohci, card); } @@ -174,17 +174,17 @@ extern inline struct fw_ohci *fw_ohci(st static char ohci_driver_name[] = KBUILD_MODNAME; -extern inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data) +static inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data) { writel(data, ohci->registers + offset); } -extern inline u32 reg_read(const struct fw_ohci *ohci, int offset) +static inline u32 reg_read(const struct fw_ohci *ohci, int offset) { return readl(ohci->registers + offset); } -extern inline void flush_writes(const struct fw_ohci *ohci) +static inline void flush_writes(const struct fw_ohci *ohci) { /* Do a dummy read to flush writes. */ reg_read(ohci, OHCI1394_Version);