Date: Wed, 3 Mar 2010 19:00:48 GMT From: Linux Kernel Mailing List To: git-commits-head@vger.kernel.org Subject: firewire: core: fix an information leak Gitweb: http://git.kernel.org/linus/137d9ebfdbaa45c01f9f0f6d5121ae6f1eb942bd Commit: 137d9ebfdbaa45c01f9f0f6d5121ae6f1eb942bd Parent: 58aaa5427663b680030aa58aaaf1e2738564b8dc Author: Stefan Richter AuthorDate: Fri Feb 19 21:00:02 2010 +0100 Committer: Stefan Richter CommitDate: Wed Feb 24 20:36:54 2010 +0100 firewire: core: fix an information leak If a device exposes a sparsely populated configuration ROM, firewire-core's sysfs interface and character device file interface showed random data in the gaps between config ROM blocks. Fix this by zero-initialization of the config ROM reader's scratch buffer. Signed-off-by: Stefan Richter --- drivers/firewire/core-device.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index 150a8ba..f612119 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -514,6 +514,7 @@ static int read_bus_info_block(struct fw_device *device, int generation) return -ENOMEM; stack = &rom[READ_BIB_ROM_SIZE]; + memset(rom, 0, sizeof(*rom) * READ_BIB_ROM_SIZE); device->max_speed = SCODE_100;